-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the otlpmetric/internal package and sub-packages #4420
Conversation
I think we should also deprecate |
Will this cause issues for users if there are sub-modules and sub-packages that are not deprecated?
SGTM. We should also do the same for the
👍 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4420 +/- ##
=====================================
Coverage 83.5% 83.5%
=====================================
Files 229 229
Lines 18679 18679
=====================================
+ Hits 15605 15607 +2
+ Misses 2755 2753 -2
Partials 319 319
|
AFAIK it should not cause any problem. Anyway verifying on a "test" repository would be safer than trusting me 😉 Still I think the PR can be merged as it is. |
The plan is to remove this package after this has been released.
Part of #3846