Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the otlptrace/internal packages #4425

Merged
merged 7 commits into from
Aug 10, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 8, 2023

Part of #3846

The initial idea for otlptrace/internal was to keep it around going forward after everything had been copied to the sub-modules. This was decided against last SIG meeting as publishing a deprecated package and then removing the package (i.e. stop publishing new packages) should provide the same use-case to users. With that goal, this PR does the following:

Stop generating and deprecate:

  • otlptrace/internal/envconfig
  • otlptrace/internal
  • otlptrace/internal/otlpconfig
  • otlptrace/internal/otlptracetest
  • otlptrace/internal/retry

Stop generating (it is only used in otlptrace):

  • otlptrace/internal/tracetransform

Note: otlptrace/internal/envconfig and otlptrace/internal/retry have not been released yet. They are still deprecated instead of removed so the soon-to-be-released other internal packages will not have cross-module dependencies in their last release and ultimately fix the issue for users that upgrade to their latest value.

@MrAlias MrAlias added the pkg:exporter:otlp Related to the OTLP exporter package label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4425 (a1da462) into main (10d9038) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4425     +/-   ##
=======================================
- Coverage   81.2%   81.2%   -0.1%     
=======================================
  Files        247     247             
  Lines      20006   20006             
=======================================
- Hits       16256   16254      -2     
- Misses      3407    3409      +2     
  Partials     343     343             
Files Changed Coverage Δ
...ers/otlp/otlptrace/internal/envconfig/envconfig.go 86.4% <ø> (ø)
exporters/otlp/otlptrace/internal/header.go 100.0% <ø> (ø)
...rs/otlp/otlptrace/internal/otlpconfig/envconfig.go 89.5% <ø> (ø)
...ters/otlp/otlptrace/internal/otlpconfig/options.go 82.8% <ø> (ø)
...xporters/otlp/otlptrace/internal/otlpconfig/tls.go 62.5% <ø> (ø)
exporters/otlp/otlptrace/internal/retry/retry.go 98.3% <ø> (ø)
...tlp/otlptrace/internal/tracetransform/attribute.go 100.0% <ø> (ø)
...lptrace/internal/tracetransform/instrumentation.go 100.0% <ø> (ø)
...otlp/otlptrace/internal/tracetransform/resource.go 100.0% <ø> (ø)
...ers/otlp/otlptrace/internal/tracetransform/span.go 96.5% <ø> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 9, 2023
@MrAlias MrAlias merged commit 319cb3a into open-telemetry:main Aug 10, 2023
21 checks passed
@MrAlias MrAlias deleted the dep-otlptrace-internal branch August 10, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants