-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the otlptrace/internal
packages
#4425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4425 +/- ##
=======================================
- Coverage 81.2% 81.2% -0.1%
=======================================
Files 247 247
Lines 20006 20006
=======================================
- Hits 16256 16254 -2
- Misses 3407 3409 +2
Partials 343 343
|
MrAlias
force-pushed
the
dep-otlptrace-internal
branch
from
August 8, 2023 18:38
a5d3f42
to
55803bb
Compare
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
August 8, 2023 18:44
pellared
approved these changes
Aug 9, 2023
dashpole
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3846
The initial idea for
otlptrace/internal
was to keep it around going forward after everything had been copied to the sub-modules. This was decided against last SIG meeting as publishing a deprecated package and then removing the package (i.e. stop publishing new packages) should provide the same use-case to users. With that goal, this PR does the following:Stop generating and deprecate:
otlptrace/internal/envconfig
otlptrace/internal
otlptrace/internal/otlpconfig
otlptrace/internal/otlptracetest
otlptrace/internal/retry
Stop generating (it is only used in
otlptrace
):otlptrace/internal/tracetransform
Note:
otlptrace/internal/envconfig
andotlptrace/internal/retry
have not been released yet. They are still deprecated instead of removed so the soon-to-be-released other internal packages will not have cross-module dependencies in their last release and ultimately fix the issue for users that upgrade to their latest value.