Add lint to check for known cross-module internal packages #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
pellared
reviewed
Aug 9, 2023
|
I want to say that I like this 👍 It will help also double-check that #3846 is implemented correctly. |
MrAlias
commented
Aug 10, 2023
pellared
approved these changes
Aug 11, 2023
dashpole
approved these changes
Aug 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4426 +/- ##
=======================================
- Coverage 78.8% 78.8% -0.1%
=======================================
Files 253 253
Lines 20644 20644
=======================================
- Hits 16283 16281 -2
- Misses 4012 4014 +2
Partials 349 349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3846
Help prevent a revert of all the changes made to remove cross module internal package dependencies.