Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cardinality limiting to the metric SDK as an experimental feature #4457

Merged
merged 23 commits into from
Dec 19, 2023
Merged

Add cardinality limiting to the metric SDK as an experimental feature #4457

merged 23 commits into from
Dec 19, 2023

Commits on Aug 18, 2023

  1. Add agg limiting func

    @MrAlias
    MrAlias committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    3bc9dcc View commit details
    Browse the repository at this point in the history

  2. Add unit test for limitAttr

    @MrAlias
    MrAlias committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    c8ce214 View commit details
    Browse the repository at this point in the history

  3. Add limiting to aggregate types

    @MrAlias
    MrAlias committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    c79f14e View commit details
    Browse the repository at this point in the history

  4. Add internal x pkg for experimental feature-flagging

    @MrAlias
    MrAlias committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    6aa1640 View commit details
    Browse the repository at this point in the history

  5. Connect cardinality limit to metric SDK

    @MrAlias
    MrAlias committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    cc11cb0 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Merge branch 'main' into cardinality-limit-x

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    07dc9b9 View commit details
    Browse the repository at this point in the history

  2. Replace limitAttr fn with limiter type 

    The Attribute method is still inlinable.
    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    62311eb View commit details
    Browse the repository at this point in the history

  3. Use x.CardinalityLimit directly

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b53c71c View commit details
    Browse the repository at this point in the history

  4. Simplify limiter test

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    92efe65 View commit details
    Browse the repository at this point in the history

  5. Add limiter benchmark

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    27df16c View commit details
    Browse the repository at this point in the history

  6. Document the AggregationLimit field

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    c2d5246 View commit details
    Browse the repository at this point in the history

  7. Test sum limits

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    426b29d View commit details
    Browse the repository at this point in the history

  8. Test limit for last value

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    3a59317 View commit details
    Browse the repository at this point in the history

  9. Test histogram limit

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    0354e68 View commit details
    Browse the repository at this point in the history

  10. Refactor expo hist test to use existing fixtures 

    The tests for the exponential histogram create their own testing
fixtures. There is nothing these new fixtures do that cannot already be
done with the existing testing fixtures used by all the other aggregate
functions. Unify the exponential histogram testing to use the existing
fixtures.
    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f1f3be7 View commit details
    Browse the repository at this point in the history

  11. Test the ExponentialHistogram limit

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    4874fcb View commit details
    Browse the repository at this point in the history

  12. Fix lint

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    3fa01f1 View commit details
    Browse the repository at this point in the history

  13. Add docs

    @MrAlias
    MrAlias committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    ea4fe06 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Merge branch 'main' into cardinality-limit-x

    @MrAlias
    MrAlias committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    b022999 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Rename aggregation field to aggLimit

    @MrAlias
    MrAlias committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5bc739e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into cardinality-limit-x

    @MrAlias
    MrAlias authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    320fee0 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Merge branch 'main' into cardinality-limit-x

    @MrAlias
    MrAlias authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    a8fbbf7 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Merge branch 'main' into cardinality-limit-x

    @pellared
    pellared authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    41f950b View commit details
    Browse the repository at this point in the history