Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor propagators #467

Merged
merged 6 commits into from
Feb 14, 2020
Merged

Refactor propagators #467

merged 6 commits into from
Feb 14, 2020

Commits on Feb 12, 2020

  1. Remove binary propagators 

    They are in process of being dropped from the specification and we
haven't be using them anywhere in the project. Can reintroduce them
later.
    @jmacd @krnowak
    jmacd authored and krnowak committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    510103a View commit details
    Browse the repository at this point in the history

  2. Rename Supplier to HTTPSupplier 

    The supplier is used only in HTTP propagators currently. It's not
clear if it will be useful for binary propagators if they get to be
specified at some point.
    @jmacd @krnowak
    jmacd authored and krnowak committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    e477122 View commit details
    Browse the repository at this point in the history

  3. Rework propagation interfaces 

    The biggest change here is that HTTP extractors return a new context
with whatever information the propagator is able to retrieve from the
supplier. Such interface does not hardcode any extractor's
functionality (like it was before by explicitly returning a span
context and correlation context) and makes it easy to chain multiple
propagators.

Injection part hasn't changed.
    @jmacd @krnowak
    jmacd authored and krnowak committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    35ec56f View commit details
    Browse the repository at this point in the history

  4. Add Propagators interface 

    This interface (and its default implementation) is likely going to be
the propagation API used the most. Single injectors, extractors or
propagators are likely going to be used just as parameters to the
Option functions that configure the Propagators implementation.
    @jmacd @krnowak
    jmacd authored and krnowak committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    97a2bcf View commit details
    Browse the repository at this point in the history

  5. Drop noop propagator 

    It's rather pointless - just create an empty Propagators instance.
    @jmacd @krnowak
    jmacd authored and krnowak committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    9a68371 View commit details
    Browse the repository at this point in the history

  6. Fix wrong name in docs

    @krnowak
    krnowak committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    82d2a28 View commit details
    Browse the repository at this point in the history