Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlptracehttp, otlpmetrichttp: Retry temporary HTTP request failures #4679

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

pellared
Copy link
Member

Fixes #4663

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #4679 (131a2d9) into main (aea3eab) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4679   +/-   ##
=====================================
  Coverage   81.6%   81.6%           
=====================================
  Files        225     225           
  Lines      17983   17991    +8     
=====================================
+ Hits       14682   14694   +12     
+ Misses      3001    2997    -4     
  Partials     300     300           
Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 80.4% <100.0%> (+1.6%) ⬆️
exporters/otlp/otlptrace/otlptracehttp/client.go 76.5% <100.0%> (-1.1%) ⬇️

... and 2 files with indirect coverage changes

@pellared pellared merged commit 5ec67e8 into open-telemetry:main Oct 31, 2023
25 checks passed
@pellared pellared deleted the fix-4663 branch October 31, 2023 07:06
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otlptracehttp otlpmetrichttp: Handling errors and retries for HTTP requests
4 participants