improve trace_context performance #4721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* using strings.Builder instead of fmt.Sprint * using strings.Cut instead of strings.Split * using hex.Decode instead of hex.DecodeString * avoid use regexp
xiehuc
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4721 +/- ##
=======================================
+ Coverage 81.8% 81.9% +0.1%
=======================================
Files 224 224
Lines 18113 18116 +3
=======================================
+ Hits 14817 14847 +30
+ Misses 3000 2982 -18
+ Partials 296 287 -9
|
|
|
@MrAlias please check again, thanks |
|
It seems like I was confusing old vs new in my last comment. The benchstat output was helpful in clarifying this. |
MrAlias
reviewed
Nov 17, 2023
|
@MrAlias all suggestion modified, please check again, thanks |
MrAlias
approved these changes
Nov 28, 2023
|
newest code benchmark result |
|
@MrAlias all comment fixed, please check again, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagation is essential logic, regardless of whether it hits sampling. In the past, the implementation of Propagation did not prioritize memory management, allocating a lot of temporary heap memory. This caused its efficiency to be low. In some scenarios, too much CPU was wasted.
For example, even if it doesn't hit sampling, startServerSpan consumes 25% of the entire request CPU.
Typical server span Propagation:
Typical client span Propagation
It can be seen that the poor performance of Propagation is mainly due to regular expressions and Sprintf.
This CR can significantly improve Propagation by optimizing it in the following ways:
Use string.Builder to pre-allocate memory
Use hex.Decode to a stack-based [N]byte array instead of hex.DecodeString, which temporarily allocates a heap-based string.
Use strings.Cut instead of strings.Split
Avoid using regex
All unit tests pass. Benchmarks:
New logic:
Old logic:
It can be seen that the performance has improved by about 2-3 times.