Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Span#RecordError method to simplify adding error events to spans #473

Merged
merged 10 commits into from
Feb 28, 2020
Merged

Add Span#RecordError method to simplify adding error events to spans #473

merged 10 commits into from
Feb 28, 2020

Commits on Feb 11, 2020

  1. Add Span#Error method to simplify setting an error status and message.

    @Aneurysm9
    Aneurysm9 committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    96d77ed View commit details
    Browse the repository at this point in the history

  2. Span#Error should no-op on nil errors

    @Aneurysm9
    Aneurysm9 committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    d7c6561 View commit details
    Browse the repository at this point in the history

  3. Record errors as a span event rather than status/attributes. 

    The implementation in the SDK package now relies on existing API methods.
    @Aneurysm9
    Aneurysm9 committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    1e4e454 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2020

  1. Merge branch 'master' of https://github.com/open-telemetry/openteleme… 

    …try-go into OTG-248
    @Aneurysm9
    Aneurysm9 committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    5aa80ed View commit details
    Browse the repository at this point in the history

  2. Add WithErrorStatus() ErrorOption to allow setting span status on error.

    @Aneurysm9
    Aneurysm9 committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    02fb7dc View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Krzesimir Nowak <qdlacz@gmail.com>
    @Aneurysm9 @krnowak
    Aneurysm9 and krnowak authored Feb 18, 2020
    Configuration menu
    Copy the full SHA
    50f19bc View commit details
    Browse the repository at this point in the history

  2. Address code review feedback

    @Aneurysm9
    Aneurysm9 committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    a9a11ce View commit details
    Browse the repository at this point in the history

  3. Clean up RecordError tests 

    * Ensure complete and unique error type is recorded for defined types
* Avoid duplicating logic under test in tests
    @Aneurysm9
    Aneurysm9 committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    b3ae96c View commit details
    Browse the repository at this point in the history

  4. Move TestError to internal/testing package, improve RecordError test … 

    …scenarios
    @Aneurysm9
    Aneurysm9 committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    9363960 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Merge branch 'master' into OTG-248

    @Aneurysm9
    Aneurysm9 authored Feb 27, 2020
    Configuration menu
    Copy the full SHA
    2e932cb View commit details
    Browse the repository at this point in the history