-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baggage: Fix escaping in Member.String #4756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4756 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 226 226
Lines 18342 18344 +2
=====================================
+ Hits 15085 15087 +2
Misses 2975 2975
Partials 282 282
|
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
December 14, 2023 20:51
dmathieu
approved these changes
Dec 19, 2023
MrAlias
reviewed
Dec 19, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Dec 20, 2023
I created: I am waiting until tomorrow before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
%20
(whitespace) is improperly encoded as+
.Test
TestMemberString
result before the fix:I noticed the bug when working on #4755.
What
Only CTLs, whitespace, DQUOTE, comma, semicolon, backslash have to be escaped.
Characters like
+
,=
,-
do NOT need to be escaped - they are acceptable. Therefore, some tests are updated as they are no longer escaped.Reference: https://www.w3.org/TR/baggage/#definition
Take notice that
url.PathUnescape
is used for decoding then it also makes more sense to useurl.PathEscape
to encode. Not mentioning that usingurl.QueryEscape
simply produces invalid value.