-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the experimental exemplar feature #4871
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4871 +/- ##
=======================================
+ Coverage 82.5% 82.6% +0.1%
=======================================
Files 231 232 +1
Lines 18762 18872 +110
=======================================
+ Hits 15488 15600 +112
+ Misses 2985 2982 -3
- Partials 289 290 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation looks good, but it looks like it needs unit tests?
Right. Added c589d01 PTAL |
c589d01
to
22b463d
Compare
This only has a single use.
Default and invalid OTEL_METRICS_EXEMPLAR_FILTER. Test sampled and non-sampled context for trace_based.
Integrate the exemplar package into the metric SDK as an experimental feature.
Closes #4455
Resolves #559
Benchmark