-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trace: SpanFromContext and SpanContextFromContext make no allocs #5049
Merged
pellared
merged 6 commits into
open-telemetry:main
from
pellared:zero-alloc-SpanFromContext
Mar 12, 2024
Merged
trace: SpanFromContext and SpanContextFromContext make no allocs #5049
pellared
merged 6 commits into
open-telemetry:main
from
pellared:zero-alloc-SpanFromContext
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5049 +/- ##
=====================================
Coverage 83.4% 83.4%
=====================================
Files 238 238
Lines 15745 15745
=====================================
Hits 13145 13145
Misses 2312 2312
Partials 288 288
|
pellared
changed the title
trace: SpanFromContext has no allocs
trace: SpanFromContext and SpanContextFromContext make no allocs
Mar 11, 2024
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
March 11, 2024 12:30
dmathieu
approved these changes
Mar 11, 2024
dashpole
approved these changes
Mar 11, 2024
MrAlias
approved these changes
Mar 11, 2024
XSAM
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this
SpanFromContext
andSpanContextFromContext
produce an allocation when the provided context has no span (e.g.nil
,context.Background
).Discovered when working on: #4955