Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Summary support to the OTLP exporter #5100

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

dashpole
Copy link
Contributor

Fixes open-telemetry/opentelemetry-go-contrib#5296

This adds Summary support to the OTLP exporter. Without this, bridges that produce summary metrics aren't very useful.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.8%. Comparing base (32e3a3d) to head (eea7a1d).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5100   +/-   ##
=====================================
  Coverage   83.8%   83.8%           
=====================================
  Files        248     248           
  Lines      16147   16201   +54     
=====================================
+ Hits       13535   13589   +54     
  Misses      2324    2324           
  Partials     288     288           
Files Coverage Δ
...ic/otlpmetricgrpc/internal/transform/metricdata.go 100.0% <100.0%> (ø)
...ic/otlpmetrichttp/internal/transform/metricdata.go 100.0% <100.0%> (ø)

@MrAlias MrAlias merged commit 540663b into open-telemetry:main Mar 25, 2024
27 checks passed
@dashpole dashpole deleted the otlp_summary branch March 25, 2024 15:18
@MrAlias MrAlias added this to the v1.25.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bridges/prometheus] "unknown aggregation" error when transforming ScopeMetrics
5 participants