Add support for AddLink to the OpenCensus bridge #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
added
pkg:bridges
dashpole
force-pushed
the
opencensus_addlink
branch
from
9abd728
to
a956d57
Compare
dashpole
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5116 +/- ##
=====================================
Coverage 83.7% 83.8%
=====================================
Files 248 248
Lines 16230 16245 +15
=====================================
+ Hits 13600 13617 +17
+ Misses 2342 2340 -2
Partials 288 288
|
MrAlias
approved these changes
Mar 28, 2024
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
XSAM
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5113
It drops the LinkType because OTel doesn't have a link type concept.
It marks all SpanContexts as sampled, since that is in-line with w3c usage of the sampled flag.
It leaves IsRemote and TraceState at their default values.