-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otlpmetrichttp: Use go.opentelemetry.io/proto/slim/otlp #5222
Merged
pellared
merged 5 commits into
open-telemetry:main
from
pellared:otlpmetrichttp-use-slim
Apr 22, 2024
Merged
otlpmetrichttp: Use go.opentelemetry.io/proto/slim/otlp #5222
pellared
merged 5 commits into
open-telemetry:main
from
pellared:otlpmetrichttp-use-slim
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5222 +/- ##
=======================================
+ Coverage 84.5% 85.5% +0.9%
=======================================
Files 258 258
Lines 17348 17030 -318
=======================================
- Hits 14675 14570 -105
+ Misses 2362 2152 -210
+ Partials 311 308 -3
|
pellared
force-pushed
the
otlpmetrichttp-use-slim
branch
from
April 17, 2024 10:00
19fa645
to
6252eb4
Compare
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
April 17, 2024 10:17
pellared
added
pkg:exporter:otlp
Related to the OTLP exporter package
enhancement
New feature or request
labels
Apr 17, 2024
MrAlias
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
dmathieu
approved these changes
Apr 22, 2024
XSAM
added a commit
to XSAM/opentelemetry-go
that referenced
this pull request
Apr 22, 2024
…-telemetry#5222)" This reverts commit 6e92163.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:metrics
Part of OpenTelemetry Metrics
enhancement
New feature or request
pkg:exporter:otlp
Related to the OTLP exporter package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2579
I tried to do it with as minimal changes as possible while also doing some cleanups (code removal). Here is how I done it:
gotmpl
, I addedprotoImportPrefix
template variable to control the imports for the proto packages.go.opentelemetry.io/proto/slim/otlp
forotlpmetrichttp
. I did not want to go to far with the refactoring.otlpmetrichttp
package, I simply replacedgo.opentelemetry.io/proto/otlp
withgo.opentelemetry.io/proto/slim/otlp
.