Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #5763

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Fix typos #5763

merged 5 commits into from
Sep 9, 2024

Conversation

NathanBaulch
Copy link
Contributor

Just thought I'd contribute some typo fixes I stumbled upon. Nothing controversial (hopefully), just 122 simple fixes.

Use the following command to get a quick and dirty summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

  • subsciption (25)
  • invokable (23)
  • observabl (15)
  • priroritize (6)
  • assinged (5)
  • enpoint (4)
  • resouce (4)
  • reponse (3)
  • igore (3)
  • testmeter (3)
  • recoreds (3)
  • witn (3)

@NathanBaulch
Copy link
Contributor Author

There's also over 40 instances of the phrase "...represents the sHOULD be a semantic identifier..." which looks pretty wrong, but I'm not sure what it's trying to say.

@dmathieu dmathieu added the Unlock Released Changelog PRs that need to change released section in CHANGELOG.md label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.5%. Comparing base (b37e8a9) to head (daef042).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5763   +/-   ##
=====================================
  Coverage   84.5%   84.5%           
=====================================
  Files        272     272           
  Lines      22798   22798           
=====================================
+ Hits       19282   19285    +3     
+ Misses      3173    3170    -3     
  Partials     343     343           

see 2 files with indirect coverage changes

@MrAlias
Copy link
Contributor

MrAlias commented Sep 3, 2024

Thanks for fixing all these. For the most part, these look good. I would want to back out the semconv changes as they are generated files, unless you are able to find a way to have the generation tooling also make the correction.

@NathanBaulch
Copy link
Contributor Author

I agree @MrAlias - the semconv tooling typos have been fixed upstream (open-telemetry/semantic-conventions#1060 open-telemetry/semantic-conventions#1379) so those should be fixed automatically once we upgrade to the upcoming semconv/v1.28.0 (currently on semconv/v1.26.0).

@dmathieu
Copy link
Member

dmathieu commented Sep 6, 2024

The lint issue needs to be fixed (there's a generated file for which the template was not modified).

@NathanBaulch
Copy link
Contributor Author

Ah, I see it now @dmathieu, fixed.

@pellared pellared merged commit 506a9ba into open-telemetry:main Sep 9, 2024
32 checks passed
@XSAM XSAM added this to the v1.30.0 milestone Sep 9, 2024
@NathanBaulch NathanBaulch deleted the typos branch September 11, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unlock Released Changelog PRs that need to change released section in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants