Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention test-concurrent-safe CI job in CONTRIBUTING doc #5781

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Mention test-concurrent-safe CI job in CONTRIBUTING doc #5781

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d857f1
Mention `test-concurrent-safe` CI job in CONTRIBUTING doc
XSAM Sep 5, 2024
318c599
Update CONTRIBUTING.md
XSAM Sep 5, 2024
b0de9fc
Clarify subtests
XSAM Sep 5, 2024
f98fe4f
Fix format
XSAM Sep 5, 2024
c54155b
Update CONTRIBUTING.md
XSAM Sep 5, 2024
9d75f02
Merge branch 'main' into concurrent-safe-tests-doc
XSAM Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,9 @@ See also:
The tests should never leak goroutines.

Use the term `ConcurrentSafe` in the test name when it aims to verify the
absence of race conditions.
absence of race conditions. The top-level tests with this term will be run
100 times in the `test-concurrent-safe` CI job to increase the chance of
XSAM marked this conversation as resolved.
Show resolved Hide resolved
catching concurrency issues. (this does not apply to subtests)
pellared marked this conversation as resolved.
Show resolved Hide resolved

### Internal packages

Expand Down
Loading