Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: enable error-nil rule from testifylint #5843

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

Testifylint is a linter that provides best practices with the use of testify.

This PR enables error-nil rule from testifylint

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.5%. Comparing base (316114c) to head (d26b5c0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5843   +/-   ##
=====================================
  Coverage   84.5%   84.5%           
=====================================
  Files        272     272           
  Lines      22734   22734           
=====================================
+ Hits       19225   19228    +3     
+ Misses      3166    3163    -3     
  Partials     343     343           

see 2 files with indirect coverage changes

@pellared pellared merged commit d284a86 into open-telemetry:main Sep 25, 2024
31 checks passed
@mmorel-35 mmorel-35 deleted the testifylint/error-nil branch September 25, 2024 17:39
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants