-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore]: enable negative-positive rule from testifylint #5849
[chore]: enable negative-positive rule from testifylint #5849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like assert.Equal
is correct in almost all places (except one).
I believ it's probably better to keep float-compare disabled in that case. |
I agree. However, you can keep the |
d851ce9
to
93c0832
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5849 +/- ##
=====================================
Coverage 84.5% 84.5%
=====================================
Files 272 272
Lines 22734 22734
=====================================
+ Hits 19225 19226 +1
+ Misses 3166 3165 -1
Partials 343 343 |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
93c0832
to
21adde1
Compare
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables negative-positive rule from testifylint