-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timer channel drain to avoid hanging in Go 1.23 #5869
Merged
dmathieu
merged 6 commits into
open-telemetry:main
from
dany74q:danny/fix-go-1-23-timer-channel-drain
Oct 4, 2024
Merged
Fix timer channel drain to avoid hanging in Go 1.23 #5869
dmathieu
merged 6 commits into
open-telemetry:main
from
dany74q:danny/fix-go-1-23-timer-channel-drain
Oct 4, 2024
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dany74q
commented
Oct 3, 2024
- Fix timer channel drain to avoid hanging in go1.23 w/ asynctimerchan=0 (Go 1.23 timer changes can lead to hangs #5868)
dany74q
requested review from
MrAlias,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
October 3, 2024 05:12
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5869 +/- ##
=======================================
- Coverage 84.5% 84.5% -0.1%
=======================================
Files 272 272
Lines 22734 22736 +2
=======================================
+ Hits 19225 19226 +1
- Misses 3166 3167 +1
Partials 343 343 |
dany74q
force-pushed
the
danny/fix-go-1-23-timer-channel-drain
branch
from
October 3, 2024 08:31
f0a5c9c
to
978fedc
Compare
pellared
reviewed
Oct 3, 2024
pellared
changed the title
#5868 - Fix timer channel drain to avoid hanging in go1.23
Fix timer channel drain to avoid hanging in Go 1.23
Oct 3, 2024
pellared
approved these changes
Oct 3, 2024
MrAlias
approved these changes
Oct 3, 2024
dmathieu
approved these changes
Oct 4, 2024
This fix is no longer needed since Go 1.23.2 thanks to fixing golang/go#69312. Credits: @ash2k |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.