Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timer channel drain to avoid hanging in Go 1.23 #5869

Merged

Conversation

dany74q
Copy link
Contributor

@dany74q dany74q commented Oct 3, 2024

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.5%. Comparing base (e500945) to head (46558ff).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5869     +/-   ##
=======================================
- Coverage   84.5%   84.5%   -0.1%     
=======================================
  Files        272     272             
  Lines      22734   22736      +2     
=======================================
+ Hits       19225   19226      +1     
- Misses      3166    3167      +1     
  Partials     343     343             

see 2 files with indirect coverage changes

@dany74q dany74q force-pushed the danny/fix-go-1-23-timer-channel-drain branch from f0a5c9c to 978fedc Compare October 3, 2024 08:31
CHANGELOG.md Outdated Show resolved Hide resolved
sdk/trace/batch_span_processor.go Show resolved Hide resolved
@pellared pellared changed the title #5868 - Fix timer channel drain to avoid hanging in go1.23 Fix timer channel drain to avoid hanging in Go 1.23 Oct 3, 2024
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 3, 2024
@dmathieu dmathieu merged commit 19877b1 into open-telemetry:main Oct 4, 2024
31 checks passed
@pellared
Copy link
Member

This fix is no longer needed since Go 1.23.2 thanks to fixing golang/go#69312.

Credits: @ash2k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants