Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Cleanup interaction of exemplar and aggregation #5913

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Oct 23, 2024

Topic: #5249

This reverts commit 8041156 (PR: #5899) due to the performance degradation found by Benchmarks CI https://github.com/open-telemetry/opentelemetry-go/actions/runs/11447364022/job/31848519243

Here is the benchmark test on my machine:

goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/sdk/metric
                                       │   old.txt   │                new.txt                 │
                                       │   sec/op    │    sec/op     vs base                  │
Instrument/instrumentImpl/aggregate-10   3.378µ ± 3%   49.366µ ± 1%  +1361.40% (p=0.000 n=10)
Instrument/observable/observe-10         2.288µ ± 2%   37.791µ ± 1%  +1551.73% (p=0.000 n=10)
geomean                                  2.780µ         43.19µ       +1453.65%

                                       │   old.txt    │                 new.txt                 │
                                       │     B/op     │     B/op       vs base                  │
Instrument/instrumentImpl/aggregate-10   1.245Ki ± 1%   22.363Ki ± 0%  +1696.08% (p=0.000 n=10)
Instrument/observable/observe-10           823.0 ± 1%    17432.5 ± 0%  +2018.17% (p=0.000 n=10)
geomean                                  1.000Ki         19.51Ki       +1850.48%

                                       │  old.txt   │                new.txt                │
                                       │ allocs/op  │  allocs/op   vs base                  │
Instrument/instrumentImpl/aggregate-10   1.000 ± 0%   21.000 ± 0%  +2000.00% (p=0.000 n=10)
Instrument/observable/observe-10         1.000 ± 0%   16.000 ± 0%  +1500.00% (p=0.000 n=10)

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.6%. Comparing base (7a153a0) to head (b1d8e66).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5913   +/-   ##
=====================================
  Coverage   84.6%   84.6%           
=====================================
  Files        271     272    +1     
  Lines      22825   22834    +9     
=====================================
+ Hits       19310   19320   +10     
+ Misses      3171    3170    -1     
  Partials     344     344           

see 6 files with indirect coverage changes

@XSAM XSAM added Skip Changelog PRs that do not require a CHANGELOG.md entry area:metrics Part of OpenTelemetry Metrics labels Oct 23, 2024
@dashpole
Copy link
Contributor

It is probably from replacing nil with AlwaysOffFilter, if I had to guess.

@XSAM XSAM merged commit 3429e15 into open-telemetry:main Oct 23, 2024
32 checks passed
@XSAM XSAM deleted the revert-5899 branch October 23, 2024 17:48
@MrAlias MrAlias added this to the v1.32.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants