Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cheng-Zhen as a triager #5922

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

dmathieu
Copy link
Member

This proposes adding @scorpionknifes as a triager for the Go SIG.
While Cheng-Zhen's contributions are all in the contrib repository, we don't currently split roles between the two repos.

Cheng-Zhen's contributions in the log bridges, and his interest in being more involved with the SIG make him a nice fit to be a triager.

@dmathieu dmathieu marked this pull request as ready for review October 25, 2024 08:05
@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.6%. Comparing base (5cf73e7) to head (77e1ba2).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5922   +/-   ##
=====================================
  Coverage   84.6%   84.6%           
=====================================
  Files        272     272           
  Lines      22839   22839           
=====================================
  Hits       19325   19325           
  Misses      3170    3170           
  Partials     344     344           

Copy link
Member

@scorpionknifes scorpionknifes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmathieu!

CONTRIBUTING.md Outdated Show resolved Hide resolved
@dmathieu dmathieu force-pushed the scorpionknifes-triager branch from 6c132a8 to 5a9c462 Compare October 25, 2024 08:49
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmathieu dmathieu merged commit 078b2dd into open-telemetry:main Oct 28, 2024
32 checks passed
@dmathieu dmathieu deleted the scorpionknifes-triager branch October 28, 2024 08:26
pellared pushed a commit to open-telemetry/opentelemetry-go-contrib that referenced this pull request Oct 29, 2024
Follows open-telemetry/opentelemetry-go#5922

Remove affiliations from the emeritus maintainers, following
open-telemetry/opentelemetry-go#5887
@MrAlias MrAlias added this to the v1.32.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants