Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrent comments for the metric data storage location #5999

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

yumosx
Copy link
Contributor

@yumosx yumosx commented Nov 23, 2024

replace the term "out" with "rm" for better clarity,
original comments referred to "out", which can be ambiguous in this contexts

Collect(ctx context.Context, rm *metricdata.ResourceMetrics) error

Copy link

linux-foundation-easycla bot commented Nov 23, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

sdk/metric/reader.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually want a changelog entry for it? 😉

@dmathieu
Copy link
Member

Yes, that changelog entry may also be removed, I agree.

@pellared pellared added the documentation Provides helpful information label Nov 25, 2024
@pellared pellared added this to the v1.33.0 milestone Nov 25, 2024
@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (8b510c3) to head (567a8f6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5999   +/-   ##
=====================================
  Coverage   82.1%   82.1%           
=====================================
  Files        273     273           
  Lines      23616   23616           
=====================================
+ Hits       19400   19402    +2     
+ Misses      3871    3869    -2     
  Partials     345     345           

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@pellared
Copy link
Member

Merging as trivial.

@pellared pellared merged commit e90ab80 into open-telemetry:main Nov 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants