Create a new recorder rather than reuse when multiple observations in same epoch #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantorrie
requested review from
jmacd,
krnowak,
lizthegrey,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
|
@lizthegrey Do you know why the PRs I open never seem to build automatically? Is there something I need to configure on my side? |
jmacd
approved these changes
Apr 2, 2020
| if lrec.modifiedEpoch == a.meter.currentEpoch { | ||
| // last value wins for Observers, so if we see the same labels | ||
| // in the current epoch, we replace the old recorder | ||
| lrec.recorder = a.meter.batcher.AggregatorFor(&a.descriptor) |
There was a problem hiding this comment.
I think I like this approach because it uses no extra memory unless the caller produces multiple observations.
There was a problem hiding this comment.
(Not sure why I typed "I think" above. I like this approach.)
rghetia
approved these changes
Apr 2, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564
@jmacd Is this approach acceptable for addressing the last observer value wins? I know you previously mentioned we should wait until OTEP 88 is merged, but this seems to be a very simple (possibly too simple?) way to address this.