Update the OTLP exporter batching of traces #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of batching based on the Resource pointer which is not guaranteed to uniquely identify common Resources, use the `String` method which is. Renames the external test package to be identified as the integration testing. This testing structure (the mock exporter) batches exported resources transmitted from the resource. This is needed as there is no guarantees that a batch will be exported in a single payload, therefore, it is not an ideal place to add resource batch testing for the exporter itself. Add unit tests to ensure the Exporter is correctly batching spans by resource.
MrAlias
requested review from
jmacd,
krnowak,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
rghetia
approved these changes
Apr 7, 2020
krnowak
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of batching based on the Resource pointer which is not guaranteed to uniquely identify common Resources, use the
Stringmethod which is.Renames the external test package to be identified as the integration testing. This testing structure (the mock exporter) batches exported resources transmitted from the resource. This is needed as there is no guarantees that a batch will be exported in a single payload, therefore, it is not an ideal place to add resource batch testing for the exporter itself.
Add unit tests to ensure the Exporter is correctly batching spans by resource.