Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace exporter: using type names for return values #648

Merged
merged 3 commits into from
Apr 22, 2020
Merged

trace exporter: using type names for return values #648

merged 3 commits into from
Apr 22, 2020

Conversation

moorara
Copy link
Contributor

@moorara moorara commented Apr 19, 2020

If we use type names for return values of functions, then in https://godoc.org and https://pkg.go.dev documentation the respective functions show under their types. This way, it's easier to navigate what functions are available for creating each kind of options.

@moorara
Copy link
Contributor Author

moorara commented Apr 19, 2020

I see the error message in build logs, but not sure what's the reason:

PASS
coverage: 27.5% of statements in ./...
ok  	go.opentelemetry.io/otel/exporters/otlp/internal/transform	1.037s	coverage: 27.5% of statements in ./...
FAIL
Makefile:64: recipe for target 'test-with-coverage' failed

@krnowak
Copy link
Member

krnowak commented Apr 20, 2020

I see the error message in build logs, but not sure what's the reason:

PASS
coverage: 27.5% of statements in ./...
ok  	go.opentelemetry.io/otel/exporters/otlp/internal/transform	1.037s	coverage: 27.5% of statements in ./...
FAIL
Makefile:64: recipe for target 'test-with-coverage' failed

The test is doing some shady stuff to simulate the connection dying. Looks like it's a bit flaky.

@jmacd jmacd merged commit ddad4d4 into open-telemetry:master Apr 22, 2020
@moorara moorara deleted the patch-1 branch April 22, 2020 14:15
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants