Bump golangci-lint and work around the corrupting bug #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This linter seems to provide bogus fix-up information to golangci-lint, which results in file corruption instead of fixing the issue. Since we are going to run the linter again anyway, but without the --fix mode, skip the "unused" linter explicitly for the first run - it will still have a chance to report errors on the second run.
krnowak
requested review from
jmacd,
lizthegrey,
MrAlias,
paivagustavo and
tedsuo
as code owners
MrAlias
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "unused" linter corrupts the file when run with
--fixmode, so disable it for this run. It will still report stuff on the second run, without the--fixmode.Closes #665.