Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Traceparent to traceparent #681

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Fix Traceparent to traceparent #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dba86e7
Fix Traceparent to traceparent
tensorchen Apr 30, 2020
895ac33
Fix unittest Traceparent to traceparent
tensorchen Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/trace/testtrace/trace_context_propagator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ func TestInjectTraceContextToHTTPReq(t *testing.T) {

func TestTraceContextPropagator_GetAllKeys(t *testing.T) {
var propagator trace.TraceContext
want := []string{"Traceparent"}
want := []string{"traceparent"}
got := propagator.GetAllKeys()
if diff := cmp.Diff(got, want); diff != "" {
t.Errorf("GetAllKeys: -got +want %s", diff)
Expand Down
2 changes: 1 addition & 1 deletion api/trace/trace_context_propagator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
const (
supportedVersion = 0
maxVersion = 254
traceparentHeader = "Traceparent"
traceparentHeader = "traceparent"
)

// TraceContext propagates SpanContext in W3C TraceContext format.
Expand Down