Fix unary gRPC interceptor adding event for nil message on error #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htdvisser
requested review from
Aneurysm9,
jmacd,
krnowak,
lizthegrey,
MrAlias,
paivagustavo and
tedsuo
as code owners
jmacd
approved these changes
May 8, 2020
|
#695 was just merged. It should be clear to add tests covering this without any conflict. |
|
Hi @MrAlias and @Aneurysm9, #695 only added tests for the client interceptors, and not for the server interceptors. I think it would take quite a bit of time for me to add such tests, and I don't have that time right now. I'll close this pull request for now. When I have time in the future, I'll try to implement server interceptor tests and re-submit the fix for the panic. |
jmacd
added a commit
that referenced
this pull request
May 19, 2020
Fixes unresolved issue identified in #691 and attempted in #697. Adds unit test to ensure the UnaryServerInfo function does not panic during an error returned from the handler and appropriately annotates the span with the correct event. Restructures the interceptor to remove this class of errors. Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the patch I suggested in #691 to fix the gRPC interceptor panicking when a handler returns
nil, someErr.