Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evantorrie as an approver #713

Merged
merged 4 commits into from
May 12, 2020

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented May 11, 2020

Requirements

@jmacd jmacd requested a review from MrAlias as a code owner May 11, 2020 17:07
@lizthegrey
Copy link
Member

When was @evantorrie added as an approver?

@jmacd
Copy link
Contributor Author

jmacd commented May 11, 2020

It was a while ago.
open-telemetry/community#337

(I am starting to understand the complicated process of adding an approver.)

@MrAlias
Copy link
Contributor

MrAlias commented May 11, 2020

@jmacd I think that PR was just adding him to the OTel community. I wasn't aware of the approver nomination.

I'm not opposed, but don't know if the requirements are met.

@jmacd
Copy link
Contributor Author

jmacd commented May 11, 2020

Oh. See, apparently I still do not understand the complicated process.
Is this documented somewhere? (Ahhh!)
I nominate evantorrie and he's met the requirements.
https://github.com/open-telemetry/opentelemetry-go/pulls?q=is%3Apr+is%3Aclosed+author%3Aevantorrie

@lizthegrey
Copy link
Member

#687 is a current checklist

@Aneurysm9
Copy link
Member

@MrAlias
Copy link
Contributor

MrAlias commented May 11, 2020

Oh. See, apparently I still do not understand the complicated process.
Is this documented somewhere? (Ahhh!)
I nominate evantorrie and he's met the requirements.
https://github.com/open-telemetry/opentelemetry-go/pulls?q=is%3Apr+is%3Aclosed+author%3Aevantorrie

This looks correct to me. Have we verified that @evantorrie wants the approver status?

I'm good with updating this PR to match #687 and make it official if he is.

@jmacd jmacd changed the title Update CODEOWNERS Add evantorrie as an approver May 11, 2020
@jmacd
Copy link
Contributor Author

jmacd commented May 11, 2020

@evantorrie Can you confirm that you are interested in becoming an approver? I thought this was the case, but I could be mistaken.

@jmacd jmacd closed this May 12, 2020
@evantorrie
Copy link
Contributor

@jmacd Oops, sorry. Was AFK for a couple of days. Originally I just had asked for membership status, because I didn't have that - but I am happy to take on Approver as well if you feel I meet the requirements.

@evantorrie evantorrie reopened this May 12, 2020
@jmacd jmacd merged commit 88100f0 into open-telemetry:master May 12, 2020
@jmacd jmacd deleted the jmacd/update_codeowners branch May 12, 2020 19:16
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants