Move core and key to kv package #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tensorchen
requested review from
Aneurysm9,
evantorrie,
jmacd,
krnowak,
lizthegrey,
MrAlias and
paivagustavo
as code owners
|
This is the last step of core package refactoring. In this PR, core package will be completely eliminated. |
jmacd
reviewed
May 13, 2020
| // allowed character set in the key depends on the use of the key. | ||
| type Key string | ||
|
|
||
| // NewKey creates a new key with a passed name. |
There was a problem hiding this comment.
I wonder if we can now just remove this function. The caller can use kv.Key(...) instead of NewKey, that reads better to me.
Closed
Aneurysm9
approved these changes
May 13, 2020
| @@ -17,4 +17,4 @@ | |||
| // | |||
There was a problem hiding this comment.
The copied documentation above this line is no longer correct. This package doesn't provide "values, numbers[, or] span contexts".
|
I will follow immediately with a removal for NewKey. This change is difficult to work with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #704
This relates to #261