Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix String in Infer #746

Merged
merged 1 commit into from
May 19, 2020
Merged

Fix String in Infer #746

merged 1 commit into from
May 19, 2020

Conversation

vmihailenco
Copy link
Contributor

No description provided.

@lizthegrey
Copy link
Member

Can you provide a test?

jmacd
jmacd approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is covered by existing tests, I suspect.)

@jmacd jmacd merged commit 9adedba into open-telemetry:master May 19, 2020
@lizthegrey
Copy link
Member

(This is covered by existing tests, I suspect.)

My point was, the tests passed before and pass after this change. so what was fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vmihailenco @lizthegrey @jmacd @MrAlias