Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the SumObserver instrument #747

Merged
merged 2 commits into from
May 19, 2020
Merged

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented May 19, 2020

Part of #729, bringing the code up to 5 of 6 instruments.

@jmacd jmacd added the area:metrics Part of OpenTelemetry Metrics label May 19, 2020
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📈

@MrAlias MrAlias added this to the Beta v0.6 milestone May 19, 2020
@jmacd jmacd merged commit c5f2252 into open-telemetry:master May 19, 2020
@jmacd jmacd deleted the jmacd/sum_observer branch May 20, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants