Add a pull controller, use it for Prometheus #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
evantorrie,
lizthegrey,
MrAlias and
paivagustavo
as code owners
MrAlias
approved these changes
May 20, 2020
added 2 commits
May 20, 2020 10:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplification of the existing code. Pulling updates is backwards for the usual Export() API.
*pull.Controllerimplements aCollect()andForEach()methods, used by Prometheus. TheNewRawExporter()function is removed, as a*prometheus.Exporteralways includes its Provider. This can be extended in the future, either to support a more configurable integrators or multiple integrators.