Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Error Handling #791

Merged
merged 8 commits into from
Jun 2, 2020
Merged

Update Error Handling #791

merged 8 commits into from
Jun 2, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 2, 2020

  • Remove any one off error handlers, replacing, instead, with the global.Handle function.
  • Update tests to support new error handling.
  • Add error handling in the span SetName when span is uninitialized.

Closes #174

Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someday, someone will come along and ask why it's not possible to have per-SDK error callbacks. I propose we wait for that to happen. This is great.

internal/metric/async.go Outdated Show resolved Hide resolved
@Aneurysm9
Copy link
Member

Someday, someone will come along and ask why it's not possible to have per-SDK error callbacks. I propose we wait for that to happen. This is great.

I was thinking the same thing myself, also that I don't think it's possible to change the global handler once one is set. But, I can't point to a use case for that and it's definitely something that can be changed if needed down the road.

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
@MrAlias MrAlias merged commit eb14b39 into open-telemetry:master Jun 2, 2020
@MrAlias MrAlias deleted the err-handle branch June 2, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK should support an error callback
3 participants