Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send configured headers with every request #806

Merged
merged 4 commits into from
Jun 9, 2020

Conversation

codeboten
Copy link
Contributor

As a user, I expect that any headers I configure via WithHeaders be sent with every request sent to the collector. This PR fixes that.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me overall. I made some minor suggestions, but looks close.

exporters/otlp/otlp_integration_test.go Outdated Show resolved Hide resolved
exporters/otlp/otlp.go Outdated Show resolved Hide resolved
alrex and others added 2 commits June 9, 2020 13:53
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MrAlias MrAlias merged commit ba0203a into open-telemetry:master Jun 9, 2020
@codeboten codeboten deleted the send-headers branch June 10, 2020 15:31
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants