Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update B3 header names #881

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Update B3 header names #881

merged 2 commits into from
Jul 1, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 30, 2020

Correct the B3 single header name from X-B3 to b3.

Use the lowercase version of the B3 multiple headers. This is based on the fact that HTTP headers are case-insensitive, however, other protocols may not be.

This does not include any testing updates as there is no tests currently. I'm working on adding tests in a separate PR.

Reference

Related Issues

Resolves #765

Correct the B3 single header name from `X-B3` to `b3`.

Use the lowercase version of the B3 multiple headers. This is based on
the fact that HTTP headers are case-insensitive, however, other
protocols may not be.
@MrAlias MrAlias merged commit 8205b0b into open-telemetry:master Jul 1, 2020
@MrAlias MrAlias deleted the b3-header branch July 1, 2020 01:21
@MrAlias MrAlias mentioned this pull request Jul 9, 2020
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use lowercase B3 header names and correct single header name
3 participants