Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix B3 propagator and add tests #882

Merged
merged 38 commits into from
Jul 7, 2020

Commits on Jul 1, 2020

  1. Configuration menu
    Copy the full SHA
    5efea1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b14cc4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08e9a40 View commit details
    Browse the repository at this point in the history
  4. Add changes to Changelog.

    MrAlias committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    0a7a3fa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a89f8e6 View commit details
    Browse the repository at this point in the history
  6. Fix lint issues

    MrAlias committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    bda1e3e View commit details
    Browse the repository at this point in the history
  7. Update trace flags

    Add a new "not sampled" mask to complement the existing "sampled" one.
    
    Rename `FlagsUnused` to `FlagsUnset`.
    
    Add documentation for each of the flags to help understand their
    purpose.
    MrAlias committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    f16dc0c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a96d02f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6c6a7b2 View commit details
    Browse the repository at this point in the history
  10. Remove bogus debug flag test

    The B3 specification states "Debug is encoded as `X-B3-Flags: 1`. Absent
    or any other values can be ignored", so testing of other values should
    not result in an error.
    MrAlias committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    405be1a View commit details
    Browse the repository at this point in the history
  11. B3 Extract now supports parsing both headers

    Remove test cases that would fail if the fallback header format was
    expected to not be used.
    MrAlias committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    be56698 View commit details
    Browse the repository at this point in the history
  12. Feedback

    MrAlias committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    e7d5ed7 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    16e4bc1 View commit details
    Browse the repository at this point in the history
  14. Switch to bitmask inject encoding field

    Add the B3Encoding and valid HTTP based values. Change the B3 propagator
    to use these bitmask fields to specify the inject encoding it will
    propagate.
    MrAlias committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    3f1ea36 View commit details
    Browse the repository at this point in the history
  15. Add comments

    MrAlias committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    614e3c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Configuration menu
    Copy the full SHA
    10c345b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c37f31 View commit details
    Browse the repository at this point in the history
  3. Update comment

    MrAlias committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    727af41 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    22c4a48 View commit details
    Browse the repository at this point in the history
  5. Update trace flags

    Add a FlagsDebug and FlagsDeferred to track the B3 trace state.
    
    Add helper methods to the SpanContext to check the debug and deferred
    bit of the trace flags.
    
    Update SpanContext.IsSampled to return if the sampling decision is to
    sample rather than if the sample bit is set. This means that if the
    debug bit is also set it will return true.
    MrAlias committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    b6a2a14 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    712f879 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    49335f9 View commit details
    Browse the repository at this point in the history
  8. Update Changelog

    MrAlias committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    ee571de View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b2f3075 View commit details
    Browse the repository at this point in the history
  10. Fix Changelog formatting

    MrAlias committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    6b44a10 View commit details
    Browse the repository at this point in the history
  11. Update Changelog

    MrAlias committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    3f92d8c View commit details
    Browse the repository at this point in the history
  12. Remove valid check at start of B3 injectg

    This check makes sample only headers not propagate.
    MrAlias committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    b178c20 View commit details
    Browse the repository at this point in the history
  13. Update B3 inject integration tests

    Use the passed SpanContext and check directly the span ID.
    MrAlias committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    e882f6f View commit details
    Browse the repository at this point in the history
  14. Update B3 integration tests

    Run update checked SpanID to match sent.
    
    Add tests to validate sample only transmissions and debug flag support.
    MrAlias committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    f7d73cd View commit details
    Browse the repository at this point in the history
  15. Rename injectTest parentSc to sc

    This is no longer the parent.
    MrAlias committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    10b8832 View commit details
    Browse the repository at this point in the history
  16. Update GetAllKeys for B3

    MrAlias committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    5deb387 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Configuration menu
    Copy the full SHA
    e2868bd View commit details
    Browse the repository at this point in the history
  2. Un-Export the B3 headers

    The B3SingleHeader name will conflict with the upcoming change to prefix
    the SingleHeader encoding with "B3". There are a few options to address
    this conflict, but in the end we do not need to be exporting these
    values. They are duplicates of the OpenZipkin package and users should
    use those.
    MrAlias committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8651a69 View commit details
    Browse the repository at this point in the history
  3. Rename B3 encodings and move support method to B3Encoding

    Include a `B3` prefix to scope the encoding names.
    
    Move the related support method to the B3Encoding itself, instead of the
    B3 propagator.
    
    Add tests to provide a sanity check for encoding bitmasks.
    MrAlias committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    ee9c266 View commit details
    Browse the repository at this point in the history
  4. Update span_context_test tests

    Update test name to better describe how unused bits have no affect on
    the sampling decision. Include the inverse of this test as well: not
    sampled but has unused bits.
    MrAlias committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    68e60e8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    57c6669 View commit details
    Browse the repository at this point in the history
  6. Update api/trace/b3_propagator.go

    Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
    MrAlias and Aneurysm9 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    79be791 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cc5dae2 View commit details
    Browse the repository at this point in the history