-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix B3 propagator and add tests #882
Merged
Merged
Commits on Jul 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5efea1c - Browse repository at this point
Copy the full SHA 5efea1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b14cc4 - Browse repository at this point
Copy the full SHA 5b14cc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08e9a40 - Browse repository at this point
Copy the full SHA 08e9a40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a7a3fa - Browse repository at this point
Copy the full SHA 0a7a3faView commit details -
Configuration menu - View commit details
-
Copy full SHA for a89f8e6 - Browse repository at this point
Copy the full SHA a89f8e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for bda1e3e - Browse repository at this point
Copy the full SHA bda1e3eView commit details -
Add a new "not sampled" mask to complement the existing "sampled" one. Rename `FlagsUnused` to `FlagsUnset`. Add documentation for each of the flags to help understand their purpose.
Configuration menu - View commit details
-
Copy full SHA for f16dc0c - Browse repository at this point
Copy the full SHA f16dc0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a96d02f - Browse repository at this point
Copy the full SHA a96d02fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c6a7b2 - Browse repository at this point
Copy the full SHA 6c6a7b2View commit details -
The B3 specification states "Debug is encoded as `X-B3-Flags: 1`. Absent or any other values can be ignored", so testing of other values should not result in an error.
Configuration menu - View commit details
-
Copy full SHA for 405be1a - Browse repository at this point
Copy the full SHA 405be1aView commit details -
B3 Extract now supports parsing both headers
Remove test cases that would fail if the fallback header format was expected to not be used.
Configuration menu - View commit details
-
Copy full SHA for be56698 - Browse repository at this point
Copy the full SHA be56698View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7d5ed7 - Browse repository at this point
Copy the full SHA e7d5ed7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16e4bc1 - Browse repository at this point
Copy the full SHA 16e4bc1View commit details -
Switch to bitmask inject encoding field
Add the B3Encoding and valid HTTP based values. Change the B3 propagator to use these bitmask fields to specify the inject encoding it will propagate.
Configuration menu - View commit details
-
Copy full SHA for 3f1ea36 - Browse repository at this point
Copy the full SHA 3f1ea36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 614e3c1 - Browse repository at this point
Copy the full SHA 614e3c1View commit details
Commits on Jul 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 10c345b - Browse repository at this point
Copy the full SHA 10c345bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c37f31 - Browse repository at this point
Copy the full SHA 2c37f31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 727af41 - Browse repository at this point
Copy the full SHA 727af41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22c4a48 - Browse repository at this point
Copy the full SHA 22c4a48View commit details -
Add a FlagsDebug and FlagsDeferred to track the B3 trace state. Add helper methods to the SpanContext to check the debug and deferred bit of the trace flags. Update SpanContext.IsSampled to return if the sampling decision is to sample rather than if the sample bit is set. This means that if the debug bit is also set it will return true.
Configuration menu - View commit details
-
Copy full SHA for b6a2a14 - Browse repository at this point
Copy the full SHA b6a2a14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 712f879 - Browse repository at this point
Copy the full SHA 712f879View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49335f9 - Browse repository at this point
Copy the full SHA 49335f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee571de - Browse repository at this point
Copy the full SHA ee571deView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2f3075 - Browse repository at this point
Copy the full SHA b2f3075View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b44a10 - Browse repository at this point
Copy the full SHA 6b44a10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f92d8c - Browse repository at this point
Copy the full SHA 3f92d8cView commit details -
Remove valid check at start of B3 injectg
This check makes sample only headers not propagate.
Configuration menu - View commit details
-
Copy full SHA for b178c20 - Browse repository at this point
Copy the full SHA b178c20View commit details -
Update B3 inject integration tests
Use the passed SpanContext and check directly the span ID.
Configuration menu - View commit details
-
Copy full SHA for e882f6f - Browse repository at this point
Copy the full SHA e882f6fView commit details -
Run update checked SpanID to match sent. Add tests to validate sample only transmissions and debug flag support.
Configuration menu - View commit details
-
Copy full SHA for f7d73cd - Browse repository at this point
Copy the full SHA f7d73cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10b8832 - Browse repository at this point
Copy the full SHA 10b8832View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5deb387 - Browse repository at this point
Copy the full SHA 5deb387View commit details
Commits on Jul 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e2868bd - Browse repository at this point
Copy the full SHA e2868bdView commit details -
The B3SingleHeader name will conflict with the upcoming change to prefix the SingleHeader encoding with "B3". There are a few options to address this conflict, but in the end we do not need to be exporting these values. They are duplicates of the OpenZipkin package and users should use those.
Configuration menu - View commit details
-
Copy full SHA for 8651a69 - Browse repository at this point
Copy the full SHA 8651a69View commit details -
Rename B3 encodings and move support method to B3Encoding
Include a `B3` prefix to scope the encoding names. Move the related support method to the B3Encoding itself, instead of the B3 propagator. Add tests to provide a sanity check for encoding bitmasks.
Configuration menu - View commit details
-
Copy full SHA for ee9c266 - Browse repository at this point
Copy the full SHA ee9c266View commit details -
Update span_context_test tests
Update test name to better describe how unused bits have no affect on the sampling decision. Include the inverse of this test as well: not sampled but has unused bits.
Configuration menu - View commit details
-
Copy full SHA for 68e60e8 - Browse repository at this point
Copy the full SHA 68e60e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57c6669 - Browse repository at this point
Copy the full SHA 57c6669View commit details -
Update api/trace/b3_propagator.go
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Configuration menu - View commit details
-
Copy full SHA for 79be791 - Browse repository at this point
Copy the full SHA 79be791View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc5dae2 - Browse repository at this point
Copy the full SHA cc5dae2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.