Extend semantic convetions for RPC #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matej-g
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
paivagustavo
as code owners
|
|
Aneurysm9
reviewed
Jul 5, 2020
evantorrie
reviewed
Jul 5, 2020
|
one more thing I'm wondering, should the leading slash be also trimmed for |
Aneurysm9
approved these changes
Jul 7, 2020
jmacd
approved these changes
Jul 7, 2020
MrAlias
reviewed
Jul 7, 2020
There was a problem hiding this comment.
one more thing I'm wondering, should the leading slash be also trimmed for
RPCServiceKey?
I think the leading slash should probably addressed, but probably at the "SetName" level. I think it should probably be preserved at this level.
It looks like we use the FullMethod name when setting the name. This is introducing the leading slash. This is different than other language (Java IIRC does not have this). Probably worth tracking in an issue: #916
MrAlias
referenced
this pull request
in MrAlias/opentelemetry-go
Jul 8, 2020
Span names MUST not contain the leading slash (`/`) that the grpc package prepends to all `FullMethod` values. This replaces the `serviceFromFullMethod` function with a parsing function. This parsing function returns an span name adhering to the OpenTelemetry semantic conventions as well as formatted span attributes. Additionally, the service name needs to include the package if one exists. This updates that attribute accordingly. Once #900 is merged the method attributes can be added by uncommenting. Resolves #916
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Jul 8, 2020
MrAlias
added a commit
that referenced
this pull request
Jul 9, 2020
* Update grpctrace instrumentation span names Span names MUST not contain the leading slash (`/`) that the grpc package prepends to all `FullMethod` values. This replaces the `serviceFromFullMethod` function with a parsing function. This parsing function returns an span name adhering to the OpenTelemetry semantic conventions as well as formatted span attributes. Additionally, the service name needs to include the package if one exists. This updates that attribute accordingly. Once #900 is merged the method attributes can be added by uncommenting. Resolves #916 * Update Changelog * Update comment to plural * Switch from regexp to string parsing * Consolidate attributes before creating span * Update Changelog with addition of rpc.method in grpctrace * Fix test spanMap lookup key * Update instrumentation/grpctrace/interceptor.go Co-authored-by: ET <evantorrie@users.noreply.github.com> * Unify on explicit typed return value * Fix copy paste error Co-authored-by: ET <evantorrie@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the existing semantic conventions for RPC, in line with open-telemetry/opentelemetry-specification#604, i.e.:
rpc.systemandrpc.methodrpc.serviceto include the full service name, including package where applicableRelated Issues
Resolves #893