Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grpctrace instrumentation span names #922

Merged
merged 14 commits into from
Jul 9, 2020
Merged

Update grpctrace instrumentation span names #922

merged 14 commits into from
Jul 9, 2020

Commits on Jul 8, 2020

  1. Update grpctrace instrumentation span names 

    Span names MUST not contain the leading slash (`/`) that the grpc
package prepends to all `FullMethod` values. This replaces the
`serviceFromFullMethod` function with a parsing function. This parsing
function returns an span name adhering to the OpenTelemetry semantic
conventions as well as formatted span attributes.

Additionally, the service name needs to include the package if one
exists. This updates that attribute accordingly.

Once #900 is merged the method attributes can be added by uncommenting.

Resolves #916
    @MrAlias
    MrAlias committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    bdc35ff View commit details
    Browse the repository at this point in the history

  2. Update Changelog

    @MrAlias
    MrAlias committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    09d0048 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into grpctrace

    @MrAlias
    MrAlias committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    9d5332c View commit details
    Browse the repository at this point in the history

  4. Update comment to plural

    @MrAlias
    MrAlias committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    8d86a53 View commit details
    Browse the repository at this point in the history

  5. Switch from regexp to string parsing

    @MrAlias
    MrAlias committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    af7a91b View commit details
    Browse the repository at this point in the history

  6. Consolidate attributes before creating span

    @MrAlias
    MrAlias committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    9c93e4a View commit details
    Browse the repository at this point in the history

  7. Update Changelog with addition of rpc.method in grpctrace

    @MrAlias
    MrAlias committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    799d540 View commit details
    Browse the repository at this point in the history

  8. Fix test spanMap lookup key

    @MrAlias
    MrAlias committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    e016e0d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into grpctrace

    @MrAlias
    MrAlias authored Jul 8, 2020
    Configuration menu
    Copy the full SHA
    81692a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Update instrumentation/grpctrace/interceptor.go 

    Co-authored-by: ET <evantorrie@users.noreply.github.com>
    @MrAlias @evantorrie
    MrAlias and evantorrie authored Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ddb1c31 View commit details
    Browse the repository at this point in the history

  2. Unify on explicit typed return value

    @MrAlias
    MrAlias committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    fa42268 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into grpctrace

    @MrAlias
    MrAlias authored Jul 9, 2020
    Configuration menu
    Copy the full SHA
    537471c View commit details
    Browse the repository at this point in the history

  4. Fix copy paste error

    @MrAlias
    MrAlias committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f6e2027 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into grpctrace

    @MrAlias
    MrAlias authored Jul 9, 2020
    Configuration menu
    Copy the full SHA
    bb5ea1f View commit details
    Browse the repository at this point in the history