Make the stdout exporter a package #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the pattern of the other exporters.
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd and
lizthegrey
as code owners
Remove unused stdout exporter.
The global package does not need to be validated with the SDK. A more properly constructed end-to-end integration test should be built if this is actually needed.
jmacd
approved these changes
Jul 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching the pattern of the exporters in the project (and isolating dependencies) make the STDOUT exporter a Go package.
Additional cleanup:
globalpackage. That package does extensive testing with a mock SDK transport. If full end-to-end testing is ever needed with all the components of the project, it should be a dedicated package to integration testing.Relates to #940