Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sub-package value from kv #968

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Remove sub-package value from kv #968

merged 3 commits into from
Jul 24, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 24, 2020

Fixes #967

@MrAlias MrAlias added the pkg:API Related to an API package label Jul 24, 2020
@MrAlias MrAlias self-assigned this Jul 24, 2020
lizthegrey
lizthegrey approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@lizthegrey lizthegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking enough change that we should not release it as v0.9.1 and instead release v0.10.0

@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 24, 2020

This is a breaking enough change that we should not release it as v0.9.1 and instead release v0.10.0

Agreed.

@MrAlias MrAlias merged commit d99ac09 into open-telemetry:master Jul 24, 2020
@MrAlias MrAlias deleted the kv-flatten branch July 24, 2020 19:25
This was referenced Jul 28, 2020
Closed
Merged
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@lizthegrey lizthegrey lizthegrey approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

Assignees

@MrAlias MrAlias

Labels
pkg:API Related to an API package
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Flatten the kv package
4 participants
@MrAlias @lizthegrey @jmacd @pellared