Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated helm chart values to include the host and port and the flagd … #1126

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

bornav
Copy link
Contributor

@bornav bornav commented Apr 8, 2024

added helm chart update to include the changes in this PR open-telemetry/opentelemetry-demo#1486

@bornav bornav requested a review from puckpuck as a code owner April 8, 2024 13:42
@bornav bornav requested a review from a team April 8, 2024 13:42
EislM0203 added a commit to EislM0203/opentelemetry-helm-charts that referenced this pull request Apr 8, 2024
bumped minor version by 2 because it was already bumped to 1 by open-telemetry#1126
@bornav
Copy link
Contributor Author

bornav commented Apr 9, 2024

@puckpuck Hi, have a question regarding the Lint Charts test that failed
Rrunning locally both the generate-examples and the check-examples with the flag CHARTS=opentelemetry-demo, both make command pass without any errors.
Is the error happening right now expected or should something be reworked?

@TylerHelmuth
Copy link
Member

@bornav make sure you have all the chart dependency repos added locally and then try make generate-examples CHARTS=opentelemetry-demo again.

@TylerHelmuth TylerHelmuth merged commit c949da9 into open-telemetry:main Apr 11, 2024
3 checks passed
EislM0203 added a commit to EislM0203/opentelemetry-helm-charts that referenced this pull request Apr 15, 2024
bumped minor version by 2 because it was already bumped to 1 by open-telemetry#1126
TylerHelmuth added a commit that referenced this pull request Apr 16, 2024
* adservice add adServiceHighCpu featureflag to flagd files

* add output of make command

bumped minor version by 2 because it was already bumped to 1 by #1126

* add output of make command

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
12ushan pushed a commit to giffgaff/opentelemetry-helm-charts that referenced this pull request Jul 22, 2024
12ushan pushed a commit to giffgaff/opentelemetry-helm-charts that referenced this pull request Jul 22, 2024
…etry#1125)

* adservice add adServiceHighCpu featureflag to flagd files

* add output of make command

bumped minor version by 2 because it was already bumped to 1 by open-telemetry#1126

* add output of make command

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants