[collector] add node ip to kubeletstats

[alextricity25]

In some scenarios, it's desirable to use the node IP instead of the node name to gather kubelet metrics. This commit makes it possible for the user to specify the presets.kubeletMetrics.useNodeIp flag so that the node ip is used as an endpoint instead of the node name.

Somewhat resovles open-telemetry/opentelemetry-collector-contrib#22843

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: alextricity25 / name: Alex Cantu (8639fa7, 8cfed7d, 42758ca, d89f00c, a6fc544, 7972f9a)
• ✅ login: TylerHelmuth / name: Tyler Helmuth (79d2127)

[TylerHelmuth]

Instead of making this an option I'd be ok with switching to using Node IP in the preset instead of Node Name.

I'm actually surprised we're using node name instead of node ip as I'd expect IP to be more universally usable. We've seen issues like the one linked where IP is the solution, we could just use it all the time. I don't think it would break users.

@dmitryax @pavolloffay @jinja2 what do you think?

[jinja2]

Yeah should be okay to switch to node ip. It might be a breaking change for setups in which kubelet is not serving a certificate with the IP listed in subject alt name. Users will need to add the insecure_skip_verify: true config for such situations.

[TylerHelmuth]

It might be a breaking change for setups in which kubelet is not serving a certificate with the IP listed in subject alt name

@jinja2 how common would this be?

[alextricity25]

@TylerHelmuth Done! Latest commit removes useNodeIp and now exclusively uses K8S_NODE_IP for the kubeMetrics endpoint.

[TylerHelmuth]

Please bump the minor version of the chart and run make generate-examples CHARTS=opentelemetry-collector

[TylerHelmuth]

Error: INSTALLATION FAILED: DaemonSet.apps "opentelemetry-collector-z9u7pzlfno-agent" is invalid: spec.template.spec.containers[0].env[2].valueFrom.fieldRef.fieldPath: Invalid value: "spec.hostIp": error converting fieldPath: field label not supported: spec.hostIp

@alextricity25 looks like something with your use of the downward api is incorrect

[ChrsMark]

@alextricity25 you will need to rebase as well :).

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.