[collector] Provide alternateConfig option for use in subcharts to workaround null issue #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
changed the title
TylerHelmuth
force-pushed
the
collector-alternative-config
branch
2 times, most recently
from
95d0f27 to
75ab042
Compare
TylerHelmuth
force-pushed
the
collector-alternative-config
branch
from
75ab042 to
ea06314
Compare
povilasv
reviewed
Aug 12, 2024
jaronoff97
reviewed
Aug 13, 2024
jaronoff97
approved these changes
Aug 13, 2024
povilasv
approved these changes
Aug 19, 2024
dmitryax
reviewed
Aug 19, 2024
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
7 tasks
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no fix for helm/helm#12879 yet, this provides an alternate way to provide configuration with the collector.
This new field should really only be used when the collector is used as a subchart.
Closes #1160