docs(collector): clarify behavior of presets.kubernetesAttributes #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes preset behavior the preset applies both the k8sattributes processor as well as minimum viable RBAC rules for the collector, which should be made clear to the user. addresses open-telemetry#1377
crutonjohn
requested review from
dmitryax,
TylerHelmuth,
povilasv and
a team
as code owners
There was a problem hiding this comment.
@crutonjohn all changes inside a chart folder need a version bump. Please bump the patch version of the chart and run make generate-examples CHARTS=opentelemetry-collector
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the preset applies both the k8sattributes processor as well as minimum viable RBAC rules for the collector, which should be made clear to the user.
just tackling some low-hanging fruit in my post-kubecon hotel exhaustion.
addresses #1377