[demo] Remove duplicate envvar on frontendproxy #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OTEL_SERVICE_NAME envvar is set on all components as one of envvars listed in default.env, to the value of app.kubernetes.io/component label. Recently 51993de ("Bump dependencies and fix grafana dashboards") duplicated OTEL_SERVICE_NAME on the frontendproxy deployment by setting it explicitly to frontend-proxy. A duplicated envvar causes an error when upgrading the opentelemetry-demo chart: Deployment.apps "opentelemetry-demo-frontendproxy" is invalid: spec.template.spec.containers[0].env[0].valueFrom: Invalid value: "": may not be specified when `value` is not empty This commit removes the duplicated envvar. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
|
Thanks for spotting it @lambdanis! To update the Helm chart you also need to bump the minor version of the chart (https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-demo/Chart.yaml#L4), and then run: |
Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
|
Done, thanks for review @julianocosta89 |
dmitryax
approved these changes
Dec 1, 2024
rohanarora
pushed a commit
to rohanarora/opentelemetry-helm-charts
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTEL_SERVICE_NAME envvar is set on all components as one of envvars listed in default.env, to the value of app.kubernetes.io/component label. Recently 51993de ("Bump dependencies and fix grafana dashboards") duplicated OTEL_SERVICE_NAME on the frontendproxy deployment by setting it explicitly to frontend-proxy. A duplicated envvar causes an error when upgrading the opentelemetry-demo chart:
My understanding is that the duplicated envvar was introduced in #1422 as a follow-up to open-telemetry/opentelemetry-demo#1768 that introduced it in docker-compose setup of opentelemetry-demo? But I don't have context on why it was needed there.
cc @julianocosta89 @puckpuck as authors of the PRs.