fix(prometheusrule): simplify deployment logic #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the user specifies that they want to deploy the PrometheusRule, it should be allowed without the interference of other tangential logic such as the status of service monitors or pod monitors fix open-telemetry#1379
crutonjohn
requested review from
dmitryax,
TylerHelmuth,
povilasv and
a team
as code owners
TylerHelmuth
approved these changes
Dec 6, 2024
JaredTan95
approved these changes
Dec 6, 2024
povilasv
approved these changes
Dec 6, 2024
jaronoff97
approved these changes
Dec 6, 2024
|
Thank you for your contribution! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the user specifies that they want to deploy the PrometheusRule, it should be allowed without the interference of other tangential logic such as the status of service monitors or pod monitors
i accidentally force pushed and broke the previous PR, sorry about that. previous discussion: #1416
fix #1379
cc: @TylerHelmuth (sorry again)