fix(opentelemetry-operator): set version label with image tag if provided #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdiegosierra
changed the title
jdiegosierra
changed the title
jdiegosierra
changed the title
jaronoff97
reviewed
Dec 11, 2024
charts/opentelemetry-operator/conf/crds/crd-opentelemetrycollector.yaml
Outdated
Show resolved
Hide resolved
jdiegosierra
force-pushed
the
fix-version-label
branch
from
c9cff89 to
17d5bd4
Compare
jdiegosierra
force-pushed
the
fix-version-label
branch
from
17d5bd4 to
778cfc2
Compare
jdiegosierra
commented
Dec 12, 2024
| {{/* | ||
| Common labels | ||
| */}} | ||
| {{- define "opentelemetry-operator.labels" -}} | ||
| helm.sh/chart: {{ include "opentelemetry-operator.chart" . }} | ||
| {{ include "opentelemetry-operator.selectorLabels" . }} | ||
| {{- if .Chart.AppVersion }} |
There was a problem hiding this comment.
.Chart.AppVersion will be always defined so its not needed
jaronoff97
approved these changes
Dec 12, 2024
TylerHelmuth
approved these changes
Dec 12, 2024
jtyr
pushed a commit
to jtyr/opentelemetry-helm-charts
that referenced
this pull request
Dec 23, 2024
…ided (open-telemetry#1461) * Create app version helper * Fix description * Bump version --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
.Values.manager.image.tagis provided with a different version other thanappVersion,label app.kubernetes.io/versionstill showsappVersion.