[demo] update prometheus otlp config #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
julianocosta89
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
LGTM!
Should we also think about adding translation_strategy?
otlp:
# Ingest OTLP data keeping UTF-8 characters in metric/label names.
translation_strategy: NoUTF8EscapingWithSuffixes
https://prometheus.io/docs/guides/opentelemetry/#utf-8
I'd go for a new PR though, as all dashboards will break 🫠
I also considered adding this but realized it would break all dashboards, so I opted not to. This is absolutely something we should do in a future PR. |
TylerHelmuth
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Prometheus config for OTLP based on this guide provided in Prometheus docs.
Also fixes this issue in the demo repo.