Fix default memory_limiter configuration for helm version 3.5.x #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naseemkullah PTAL |
Starting from helm 3.5.0, merging rules were changed: now if null value merged into a dict, null value is preserved. In order to make it cleaner and working on all the versions, this commit replaces the merge operation with a conditional set. If user wants to override the default memory_limiter configuration, they should override all the fields. That behavior seems more practical than partial override for the this processor.
dmitryax
force-pushed
the
fix-chart-for-helm-3.5.x
branch
from
d508fe2 to
7d0f515
Compare
tigrannajaryan
approved these changes
Mar 22, 2021
matej-g
pushed a commit
to matej-g/opentelemetry-helm-charts
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from helm 3.5.0, merging rules were changed: now if null value merged into a dict, null value is preserved.
In order to make it cleaner and working across all helm versions, this commit replaces the merge operation with a conditional set.
If user wants to override the default memory_limiter configuration, they should override all the fields. That behavior seems more practical than partial override for the this processor.
Resolves #34